Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieval: skip payment channel creation if total price is zero #480

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Feb 1, 2021

No description provided.

@dirkmc dirkmc force-pushed the feat/zero-price-skip-paychan branch from 3ca8586 to 126d303 Compare February 1, 2021 15:31
docs/retrievalclient.mmd Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #480 (cec49f5) into master (5af7592) will decrease coverage by 1.07%.
The diff coverage is 81.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   66.12%   65.05%   -1.06%     
==========================================
  Files          50       50              
  Lines        3196     3256      +60     
==========================================
+ Hits         2113     2118       +5     
- Misses        856      911      +55     
  Partials      227      227              
Impacted Files Coverage Δ
retrievalmarket/impl/clientstates/client_fsm.go 74.34% <ø> (ø)
retrievalmarket/impl/dtutils/dtutils.go 79.44% <0.00%> (-0.74%) ⬇️
...rievalmarket/impl/requestvalidation/revalidator.go 79.57% <84.62%> (+0.16%) ⬆️
retrievalmarket/impl/clientstates/client_states.go 92.31% <100.00%> (+0.42%) ⬆️
storagemarket/impl/provider_environments.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2b4d4...cec49f5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants